From 178bf1d8b42d03c4d1b4d08ef944cc1b45d6bc56 Mon Sep 17 00:00:00 2001 From: Markus Stockhausen Date: Sun, 3 May 2026 18:57:49 +0200 Subject: [PATCH] realtek: mdio: add comment about c22/command register The C22 aka command register is a wild bit mix. Avoid confusion for reviewers and add a comment. Signed-off-by: Markus Stockhausen Link: https://github.com/openwrt/openwrt/pull/23204 Signed-off-by: Robert Marko --- .../realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c index 329bafcc96..d7c06b3f58 100644 --- a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c @@ -308,6 +308,7 @@ static int rtmdio_run_cmd(struct mii_bus *bus, int cmd, void *smi_access, u32 *v if (ret) return ret; + /* Use masks as C22 data and command bits share the same register. */ ret = regmap_update_bits(ctrl->map, ctrl->cfg->cmd_reg, ctrl->cfg->cmd_mask, cmd | RTMDIO_RUN); if (ret)