catspeed-cc/openwrt
1
1
Fork 0
Code

realtek: dts: drop EXTERNAL_SFP_PHY macro

Browse Source 
The EXTERNAL_SFP_PHY macro is very strange. It has attributes
sfp and media but is not linked to any SFP definition. There
is nothing that the kernel can evaluate better than the classic
PHY_C22 macro.

Remark! For the current D-Link DGS-1210 consumers this macro
should be converted to a PHY_C22_SFP in the future. As of now
there is no hardware to identify the proper gpios and define
and verify the corresponding SFP ports. Add a TODO comment
where needed.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/23036
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Markus Stockhausen 2026-04-21 19:25:18 +02:00 committed by Robert Marko
parent 11d49521c4
commit 26f2bc96b9
3 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
target/linux/realtek/dts/macros.dtsi
View File

@ -32,14 +32,6 @@
enet-phy-pair-order = <##po>; \
};
#define EXTERNAL_SFP_PHY(n) \
phy##n: ethernet-phy@##n { \
compatible = "ethernet-phy-ieee802.3-c22"; \
sfp; \
media = "fibre"; \
reg = <##n>; \
};
#define SWITCH_PORT(p, l, m) \
port##p: port@##p { \
reg = <##p>; \

9
target/linux/realtek/dts/rtl8382_d-link_dgs-1210-16.dts
View File

@ -28,10 +28,11 @@
PHY_C22(14, 14)
PHY_C22(15, 15)
EXTERNAL_SFP_PHY(24)
EXTERNAL_SFP_PHY(25)
EXTERNAL_SFP_PHY(26)
EXTERNAL_SFP_PHY(27)
/* TODO: This is a RTL8214FC and should be PHY_C22_SFP() */
PHY_C22(24, 24)
PHY_C22(25, 25)
PHY_C22(26, 26)
PHY_C22(27, 27)
};
&switch0 {

9
target/linux/realtek/dts/rtl8382_d-link_dgs-1210-20.dts
View File

@ -28,10 +28,11 @@
PHY_C22(14, 14)
PHY_C22(15, 15)
EXTERNAL_SFP_PHY(24)
EXTERNAL_SFP_PHY(25)
EXTERNAL_SFP_PHY(26)
EXTERNAL_SFP_PHY(27)
/* TODO: This is a RTL8214FC and should be PHY_C22_SFP() */
PHY_C22(24, 24)
PHY_C22(25, 25)
PHY_C22(26, 26)
PHY_C22(27, 27)
};
&switch0 {