From 44a38a7fcfab8777151470495eb23f0cdf48d4e3 Mon Sep 17 00:00:00 2001 From: Markus Stockhausen Date: Sun, 3 May 2026 10:12:31 +0200 Subject: [PATCH] realtek: mdio: add missing brackets to RTMDIO_PHY_POLL_MMD With its current usage type RTMDIO_PHY_POLL_MMD() definition is ok. But for the sake of consistency add brackets around the macro parameters and use masks to avoid calculation inconsistencies. Signed-off-by: Markus Stockhausen Link: https://github.com/openwrt/openwrt/pull/23204 Signed-off-by: Robert Marko --- .../realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c index 30295cf694..a222c9281c 100644 --- a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c @@ -38,7 +38,9 @@ #define RTMDIO_PHY_MAC_1G 3 #define RTMDIO_PHY_MAC_2G_PLUS 1 -#define RTMDIO_PHY_POLL_MMD(dev, reg, bit) ((bit << 21) | (dev << 16) | (reg)) +#define RTMDIO_PHY_POLL_MMD(dev, reg, bit) ((((bit) & GENMASK(3, 0)) << 21) | \ + (((dev) & GENMASK(4, 0)) << 16) | \ + ((reg) & GENMASK(15, 0))) /* MDIO bus registers/fields */ #define RTMDIO_C45_DATA(devnum, regnum) (((devnum) << 16) | ((regnum) & GENMASK(15, 0)))