From 44b809b73d9c690ca071b170e74f35dc6af942e1 Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Sat, 9 May 2026 20:31:46 +0000 Subject: [PATCH] realtek: pcs: rtl931x: reduce chattiness The SerDes setup code for RTL931x still has a lot of debug prints as pr_info from former times. A lot has changed and we don't need that rather useless chattiness anymore. We reached a state where we have a standalone setup of most hardware modes. The registers printed are still "documented" in rtpcs_931x_sds_config_hw_mode and rtpcs_93xx_sds_config_cmu. For every other issues we rely on comparison of full SerDes dumps instead of cherry-picked registers. Signed-off-by: Jonas Jelonek Link: https://github.com/openwrt/openwrt/pull/23288 Signed-off-by: Robert Marko --- .../files-6.18/drivers/net/pcs/pcs-rtl-otto.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c index b006da9f99..78e022da55 100644 --- a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c @@ -3797,11 +3797,8 @@ static int rtpcs_931x_sds_config_hw_mode(struct rtpcs_serdes *sds, static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds, enum rtpcs_sds_mode hw_mode) { - struct rtpcs_serdes *even_sds = rtpcs_sds_get_even(sds); struct rtpcs_ctrl *ctrl = sds->ctrl; enum rtpcs_sds_media sds_media; - u32 sds_id = sds->id; - u32 val; int ret; /* @@ -3811,22 +3808,6 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds, if (hw_mode == RTPCS_SDS_MODE_XSGMII) return 0; - val = rtpcs_sds_read_bits(sds, 0x1F, 0x9, 11, 6); - - pr_info("%s: fibermode %08X stored mode 0x%x", __func__, - rtpcs_sds_read(sds, 0x1f, 0x9), val); - pr_info("%s: SGMII mode %08X in 0x24 0x9", __func__, - rtpcs_sds_read(sds, 0x24, 0x9)); - pr_info("%s: CMU mode %08X stored even SDS %d", __func__, - rtpcs_sds_read(even_sds, 0x20, 0x12), even_sds->id); - pr_info("%s: serdes_mode_ctrl %08X", __func__, RTPCS_931X_SERDES_MODE_CTRL + 4 * (sds_id >> 2)); - pr_info("%s CMU page 0x24 0x7 %08x\n", __func__, rtpcs_sds_read(sds, 0x24, 0x7)); - pr_info("%s CMU page 0x26 0x7 %08x\n", __func__, rtpcs_sds_read(sds, 0x26, 0x7)); - pr_info("%s CMU page 0x28 0x7 %08x\n", __func__, rtpcs_sds_read(sds, 0x28, 0x7)); - pr_info("%s XSG page 0x0 0xe %08x\n", __func__, rtpcs_sds_read(sds, 0x40, 0xe)); - pr_info("%s XSG2 page 0x0 0xe %08x\n", __func__, rtpcs_sds_read(sds, 0x80, 0xe)); - pr_info("%s: 2.5gbit %08X", __func__, rtpcs_sds_read(sds, 0x41, 0x14)); - rtpcs_931x_sds_power(sds, false); rtpcs_931x_sds_set_mode(sds, RTPCS_SDS_MODE_OFF);