catspeed-cc/openwrt
2
1
Fork 0
Code Issues Pull Requests Activity

kernel: rtl836x: directly defer probe when mdio is missing

Browse Source 
If the switch is directly controlled by the mdio bus, we must ensure
that the mdio bus is ready instead of trying GPIO simulated bus.

Fixes: d4ac26ec49 ("kernel: rtl8366-smi: add Realtek switch management via mii-bus")
Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
Link: https://github.com/openwrt/openwrt/pull/21143
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Shiji Yang 2025-12-15 19:37:03 +08:00 committed by Hauke Mehrtens
parent 045007c24c
commit 52924bf194
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
target/linux/generic/files/drivers/net/phy/rtl8366_smi.c
View File

@ -1497,7 +1497,7 @@ static int rtl8366_smi_probe_of(struct platform_device *pdev, struct rtl8366_smi
if (!smi->ext_mbus) {
dev_info(&pdev->dev,
"cannot find mdio bus from bus handle (yet)");
goto try_gpio;
return -EPROBE_DEFER;
}
if (of_property_read_u32(np, "phy-id", &smi->phy_id))
@ -1507,12 +1507,8 @@ static int rtl8366_smi_probe_of(struct platform_device *pdev, struct rtl8366_smi
try_gpio:
if (!gpio_is_valid(sck) || !gpio_is_valid(sda)) {
if (!mdio_node) {
dev_err(&pdev->dev, "gpios missing in devictree\n");
return -EINVAL;
} else {
return -EPROBE_DEFER;
}
dev_err(&pdev->dev, "gpios missing in devictree\n");
return -EINVAL;
}
smi->gpio_sda = sda;