1
1

ath79: use led-sources for WMAC

The ath9k driver creates an ath9k LED by default. Instead of having a
non functional LED, configure it properly and remove the extra as it's
not needed.

It's also a bit funny matching against phy0 and phy1 when both differ
between ath9k and ath10k.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23191
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Rosen Penev 2026-05-02 14:41:43 -07:00 committed by Robert Marko
parent 5f3a23139f
commit 57cfe86c06
36 changed files with 189 additions and 239 deletions

View File

@ -174,12 +174,6 @@
gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
};
wireless {
label = "green:wireless";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
led_security: security {
label = "amber:security";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
@ -255,6 +249,11 @@
nvmem-cells = <&cal_art_11000>;
nvmem-cell-names = "calibration";
led {
led-sources = <6>;
led-active-low;
};
};
&uart {

View File

@ -48,13 +48,6 @@
label = "green:qss";
gpios = <&gpio 4 GPIO_ACTIVE_HIGH>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -141,4 +134,9 @@
nvmem-cells = <&macaddr_uboot_1fc00>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <9>;
led-active-low;
};
};

View File

@ -57,13 +57,6 @@
label = "green:qss";
gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
rtl8366rb {
@ -157,4 +150,9 @@
nvmem-cells = <&macaddr_uboot_1fc00>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <9>;
led-active-low;
};
};

View File

@ -53,13 +53,6 @@
label = "green:qss";
gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -179,4 +172,9 @@
nvmem-cells = <&macaddr_uboot_1fc00>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <9>;
led-active-low;
};
};

View File

@ -21,13 +21,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_ORANGE>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
configurable {
label = "green:configurable";
gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
@ -163,4 +156,8 @@
nvmem-cells = <&macaddr_art_0>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <0>;
};
};

View File

@ -53,12 +53,6 @@
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
};
wifi_green {
label = "green:wifi";
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wifi_red {
label = "red:wifi";
gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
@ -172,4 +166,9 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <15>;
led-active-low;
};
};

View File

@ -17,13 +17,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
rssi1 {
label = "green:rssi1";
gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
@ -120,4 +113,8 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <0>;
};
};

View File

@ -17,13 +17,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
eth0 {
label = "orange:eth0";
gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
@ -147,4 +140,9 @@
nvmem-cells = <&macaddr_art_6>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <0>;
led-active-low;
};
};

View File

@ -45,13 +45,6 @@
label = "green:vpn";
gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -141,4 +134,8 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <0>;
};
};

View File

@ -49,13 +49,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_BLUE>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
usb {
function = LED_FUNCTION_USB;
color = <LED_COLOR_ID_WHITE>;
@ -205,4 +198,8 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <0>;
};
};

View File

@ -44,13 +44,6 @@
label = "red:eth0";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_RED>;
gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -135,4 +128,9 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <0>;
led-active-low;
};
};

View File

@ -21,13 +21,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_RED>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
lan {
function = LED_FUNCTION_LAN;
color = <LED_COLOR_ID_GREEN>;
@ -71,4 +64,8 @@
&wmac {
status = "okay";
led {
led-sources = <0>;
};
};

View File

@ -17,13 +17,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
lan {
function = LED_FUNCTION_LAN;
color = <LED_COLOR_ID_GREEN>;
@ -162,4 +155,8 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <1>;
};
};

View File

@ -21,13 +21,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
led_power: power {
function = LED_FUNCTION_POWER;
color = <LED_COLOR_ID_GREEN>;
@ -135,4 +128,8 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <0>;
};
};

View File

@ -21,13 +21,6 @@
leds {
compatible = "gpio-leds";
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
lan {
function = LED_FUNCTION_LAN;
color = <LED_COLOR_ID_GREEN>;
@ -184,4 +177,8 @@
nvmem-cells = <&macaddr_uboot_1fc00>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <0>;
};
};

View File

@ -22,13 +22,6 @@
pinctrl-names = "default";
pinctrl-0 = <&switch_led_disable_pins>;
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 26 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
led_lan: lan {
function = LED_FUNCTION_LAN;
color = <LED_COLOR_ID_GREEN>;
@ -172,4 +165,9 @@
nvmem-cells = <&macaddr_uboot_1fc00>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <26>;
led-active-low;
};
};

View File

@ -77,13 +77,6 @@
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -169,4 +162,8 @@
nvmem-cells = <&macaddr_uboot_1fc00 0>, <&cal_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <0>;
};
};

View File

@ -38,13 +38,6 @@
gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
default-state = "on";
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_BLUE>;
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -58,6 +51,11 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <17>;
led-active-low;
};
};
&art {

View File

@ -39,13 +39,6 @@
default-state = "on";
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_AMBER>;
gpios = <&gpio 18 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
rssilow {
label = "red:rssilow";
gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
@ -89,6 +82,11 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <18>;
led-active-low;
};
};
&art {

View File

@ -42,12 +42,6 @@
default-state = "on";
};
wifi_green {
label = "green:wifi";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wifi_red {
label = "red:wifi";
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
@ -182,4 +176,9 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -48,13 +48,6 @@
default-state = "on";
};
wlan2g {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_BLUE>;
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wan {
function = LED_FUNCTION_WAN;
color = <LED_COLOR_ID_BLUE>;
@ -148,6 +141,11 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <13>;
led-active-low;
};
};
&eth0 {

View File

@ -24,13 +24,6 @@
default-state = "on";
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
qss {
label = "green:qss";
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
@ -94,4 +87,9 @@
&wmac {
status = "okay";
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -42,13 +42,6 @@
gpios = <&gpio 20 GPIO_ACTIVE_LOW>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_BLUE>;
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
led_re: re {
label = "blue:re";
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
@ -80,3 +73,10 @@
};
};
};
&wmac {
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -62,13 +62,6 @@
gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
};
wlan_green {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wlan_orange {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_ORANGE>;
@ -76,3 +69,10 @@
};
};
};
&wmac {
led {
led-sources = <2>;
led-active-low;
};
};

View File

@ -35,13 +35,6 @@
gpios = <&gpio 18 GPIO_ACTIVE_LOW>;
};
wlan {
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
qss {
label = "green:qss";
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
@ -53,3 +46,10 @@
};
};
};
&wmac {
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -27,13 +27,6 @@
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
};
led-wlan {
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_WLAN;
linux,default-trigger = "phy0tpt";
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
};
led_status: led-power {
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_POWER;
@ -57,3 +50,10 @@
phy-handle = <&phy1>;
};
&wmac {
led {
led-sources = <14>;
led-active-low;
};
};

View File

@ -23,12 +23,6 @@
color = <LED_COLOR_ID_BLUE>;
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
};
wifi5g {
label = "green:wifi5g";
gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -47,6 +41,11 @@
&wmac {
nvmem-cells = <&macaddr_art_0 (-1)>, <&calibration_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <12>;
led-active-low;
};
};
&art {

View File

@ -17,12 +17,6 @@
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
default-state = "on";
};
wifi5g {
label = "blue:wifi5g";
gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
@ -41,6 +35,11 @@
&wmac {
nvmem-cells = <&macaddr_art_0 (-1)>, <&calibration_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <12>;
led-active-low;
};
};
&art {

View File

@ -43,12 +43,6 @@
gpios = <&gpio 19 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy1tpt";
};
wifi5g {
label = "green:wifi5g";
gpios = <&gpio 18 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
virtual_flash {
@ -73,6 +67,11 @@
nvmem-cells = <&calibration_wmac>, <&macaddr_uboot_3ff80 1>;
nvmem-cell-names = "calibration", "mac-address";
led {
led-sources = <18>;
led-active-low;
};
};
&art {

View File

@ -52,12 +52,6 @@
gpios = <&gpio 20 GPIO_ACTIVE_LOW>;
};
wifi5g_green {
label = "green:wifi5g";
gpios = <&gpio 21 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wifi5g_yellow {
label = "yellow:wifi5g";
gpios = <&gpio 22 GPIO_ACTIVE_LOW>;
@ -77,3 +71,10 @@
&wdt {
status = "disabled";
};
&wmac {
led {
led-sources = <21>;
led-active-low;
};
};

View File

@ -57,12 +57,6 @@
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
};
wifi_green {
label = "green:wifi";
gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wifi_yellow {
label = "yellow:wifi";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
@ -227,6 +221,11 @@
nvmem-cells = <&macaddr_art_0 2>, <&calibration_art_1000>;
nvmem-cell-names = "mac-address", "calibration";
led {
led-sources = <16>;
led-active-low;
};
};
&pcie {

View File

@ -57,12 +57,6 @@
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
};
wifi_green {
label = "green:wifi";
gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
wifi_yellow {
label = "yellow:wifi";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
@ -187,4 +181,9 @@
nvmem-cells = <&cal_art_1000>;
nvmem-cell-names = "calibration";
led {
led-sources = <16>;
led-active-low;
};
};

View File

@ -22,15 +22,16 @@
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
};
wlan5g {
label = "green:wlan5g";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
&eth1 {
compatible = "syscon", "simple-mfd";
};
&wmac {
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -22,15 +22,16 @@
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
};
wlan5g {
label = "green:wlan5g";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
&eth1 {
compatible = "syscon", "simple-mfd";
};
&wmac {
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -22,15 +22,16 @@
color = <LED_COLOR_ID_GREEN>;
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
};
wlan5g {
label = "green:wlan5g";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
};
&eth1 {
compatible = "syscon", "simple-mfd";
};
&wmac {
led {
led-sources = <13>;
led-active-low;
};
};

View File

@ -16,12 +16,6 @@
leds: leds {
compatible = "gpio-leds";
wlan2g {
label = "green:wlan2g";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
led_system: system {
label = "green:system";
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
@ -115,3 +109,10 @@
};
};
};
&wmac {
led {
led-sources = <13>;
led-active-low;
};
};