From 83084bac959e792517cf9a8130d797f2e94ae682 Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Thu, 26 Mar 2026 13:34:38 +0000 Subject: [PATCH] realtek: dts: drop trailing semicolons after macro use Commit d52f7a4ca5 ("realtek: dts: new SWITCH_PORT_LED() macro") introduced a new macro to simplify switch port definitions and introduces usage of it for Zyxel XGS1X10-12 devices. However, this change added a DTS syntax issue because: > SWITCH_PORT_LED(...); produces > port@XX { ... };; because the macro already includes a trailing semicolon. The DT compiler doesn't like this so it fails with syntax error. Fix this by dropping the trailing semicolons after macro usages. Fixes: d52f7a4ca5 ("realtek: dts: new SWITCH_PORT_LED() macro") Signed-off-by: Jonas Jelonek Link: https://github.com/openwrt/openwrt/pull/22614 Signed-off-by: Robert Marko --- .../dts/rtl9302_zyxel_xgs1x10-12-common.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/linux/realtek/dts/rtl9302_zyxel_xgs1x10-12-common.dtsi b/target/linux/realtek/dts/rtl9302_zyxel_xgs1x10-12-common.dtsi index 6ddf6f6b93..44a7b248ee 100644 --- a/target/linux/realtek/dts/rtl9302_zyxel_xgs1x10-12-common.dtsi +++ b/target/linux/realtek/dts/rtl9302_zyxel_xgs1x10-12-common.dtsi @@ -129,14 +129,14 @@ #address-cells = <1>; #size-cells = <0>; - SWITCH_PORT_LED(0, 1, 2, 0, usxgmii); - SWITCH_PORT_LED(1, 2, 2, 0, usxgmii); - SWITCH_PORT_LED(2, 3, 2, 0, usxgmii); - SWITCH_PORT_LED(3, 4, 2, 0, usxgmii); - SWITCH_PORT_LED(4, 5, 2, 0, usxgmii); - SWITCH_PORT_LED(5, 6, 2, 0, usxgmii); - SWITCH_PORT_LED(6, 7, 2, 0, usxgmii); - SWITCH_PORT_LED(7, 8, 2, 0, usxgmii); + SWITCH_PORT_LED(0, 1, 2, 0, usxgmii) + SWITCH_PORT_LED(1, 2, 2, 0, usxgmii) + SWITCH_PORT_LED(2, 3, 2, 0, usxgmii) + SWITCH_PORT_LED(3, 4, 2, 0, usxgmii) + SWITCH_PORT_LED(4, 5, 2, 0, usxgmii) + SWITCH_PORT_LED(5, 6, 2, 0, usxgmii) + SWITCH_PORT_LED(6, 7, 2, 0, usxgmii) + SWITCH_PORT_LED(7, 8, 2, 0, usxgmii) port@24 { reg = <24>;