From 8d9103a420fe65cdaff0682c86e35143cad3aae8 Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Mon, 18 May 2026 12:52:30 +0000 Subject: [PATCH] realtek: improve DTS readability for XS1930 switches Improve the readability of the DTS files for XS1930 switches by mostly making nodes with only a single property a one-liner. This wastes less visual space and makes it more fluent to read. Signed-off-by: Jonas Jelonek Link: https://github.com/openwrt/openwrt/pull/23428 Signed-off-by: Robert Marko --- .../realtek/dts/rtl9313_zyxel_xs1930-12f.dts | 98 +++++-------------- .../realtek/dts/rtl9313_zyxel_xs1930-12hp.dts | 22 +---- .../dts/rtl9313_zyxel_xs1930-aqr813.dtsi | 47 ++------- 3 files changed, 37 insertions(+), 130 deletions(-) diff --git a/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12f.dts b/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12f.dts index e9f7629acd..42c213280a 100644 --- a/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12f.dts +++ b/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12f.dts @@ -115,41 +115,21 @@ &i2c_mst1 { status = "okay"; - i2c0: i2c@0 { - reg = <0>; - }; - i2c1: i2c@1 { - reg = <1>; - }; - i2c2: i2c@2 { - reg = <2>; - }; - i2c3: i2c@3 { - reg = <3>; - }; - i2c4: i2c@4 { - reg = <4>; - }; - i2c5: i2c@5 { - reg = <5>; - }; + i2c0: i2c@0 { reg = <0>; }; + i2c1: i2c@1 { reg = <1>; }; + i2c2: i2c@2 { reg = <2>; }; + i2c3: i2c@3 { reg = <3>; }; + i2c4: i2c@4 { reg = <4>; }; + i2c5: i2c@5 { reg = <5>; }; }; &i2c_mst2 { status = "okay"; - i2c6: i2c@6 { - reg = <6>; - }; - i2c7: i2c@7 { - reg = <7>; - }; - i2c8: i2c@8 { - reg = <8>; - }; - i2c9: i2c@9 { - reg = <9>; - }; + i2c6: i2c@6 { reg = <6>; }; + i2c7: i2c@7 { reg = <7>; }; + i2c8: i2c@8 { reg = <8>; }; + i2c9: i2c@9 { reg = <9>; }; i2c11: i2c@b { reg = <0xb>; @@ -266,51 +246,17 @@ }; }; -&port54 { - managed = "in-band-status"; -}; +&port54 { managed = "in-band-status"; }; +&port55 { managed = "in-band-status"; }; -&port55 { - managed = "in-band-status"; -}; - -&serdes2 { - tx-polarity = ; -}; - -&serdes3 { - tx-polarity = ; -}; - -&serdes4 { - tx-polarity = ; -}; - -&serdes5 { - tx-polarity = ; -}; - -&serdes6 { - tx-polarity = ; -}; - -&serdes7 { - tx-polarity = ; -}; - -&serdes8 { - tx-polarity = ; -}; - -&serdes9 { - tx-polarity = ; -}; - -&serdes10 { - tx-polarity = ; -}; - -&serdes11 { - tx-polarity = ; -}; +&serdes2 { tx-polarity = ; }; +&serdes3 { tx-polarity = ; }; +&serdes4 { tx-polarity = ; }; +&serdes5 { tx-polarity = ; }; +&serdes6 { tx-polarity = ; }; +&serdes7 { tx-polarity = ; }; +&serdes8 { tx-polarity = ; }; +&serdes9 { tx-polarity = ; }; +&serdes10 { tx-polarity = ; }; +&serdes11 { tx-polarity = ; }; diff --git a/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12hp.dts b/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12hp.dts index 007ef377d9..83d231bf8c 100644 --- a/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12hp.dts +++ b/target/linux/realtek/dts/rtl9313_zyxel_xs1930-12hp.dts @@ -53,9 +53,7 @@ &i2c_mst1 { /* PoE management MCU sits here */ - i2c3: i2c@3 { - reg = <3>; - }; + i2c3: i2c@3 { reg = <3>; }; }; &mdio_ctrl { @@ -84,19 +82,9 @@ }; }; -&port52 { - managed = "in-band-status"; -}; +&port52 { managed = "in-band-status"; }; +&port53 { managed = "in-band-status"; }; -&port53 { - managed = "in-band-status"; -}; - -&serdes10 { - tx-polarity = ; -}; - -&serdes11 { - tx-polarity = ; -}; +&serdes10 { tx-polarity = ; }; +&serdes11 { tx-polarity = ; }; diff --git a/target/linux/realtek/dts/rtl9313_zyxel_xs1930-aqr813.dtsi b/target/linux/realtek/dts/rtl9313_zyxel_xs1930-aqr813.dtsi index fb78826862..3894753b34 100644 --- a/target/linux/realtek/dts/rtl9313_zyxel_xs1930-aqr813.dtsi +++ b/target/linux/realtek/dts/rtl9313_zyxel_xs1930-aqr813.dtsi @@ -134,37 +134,14 @@ }; }; -&port0 { - managed = "in-band-status"; -}; - -&port8 { - managed = "in-band-status"; -}; - -&port16 { - managed = "in-band-status"; -}; - -&port24 { - managed = "in-band-status"; -}; - -&port32 { - managed = "in-band-status"; -}; - -&port40 { - managed = "in-band-status"; -}; - -&port48 { - managed = "in-band-status"; -}; - -&port50 { - managed = "in-band-status"; -}; +&port0 { managed = "in-band-status"; }; +&port8 { managed = "in-band-status"; }; +&port16 { managed = "in-band-status"; }; +&port24 { managed = "in-band-status"; }; +&port32 { managed = "in-band-status"; }; +&port40 { managed = "in-band-status"; }; +&port48 { managed = "in-band-status"; }; +&port50 { managed = "in-band-status"; }; &serdes6 { rx-polarity = ; @@ -186,10 +163,6 @@ tx-polarity = ; }; -&serdes12 { - tx-polarity = ; -}; +&serdes12 { tx-polarity = ; }; +&serdes13 { tx-polarity = ; }; -&serdes13 { - tx-polarity = ; -};