catspeed-cc/openwrt
2
1
Fork 0
Code Issues Pull Requests Activity

realtek: pcs: rtl930x: reduce chattiness and reg ops

Browse Source 
There is no need to be extra chatty for simple writes which set a single
bit. As a nice side effect, without the prints there's no need to have
open-coded register access when there a helper that covers that.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23288
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Jonas Jelonek 2026-05-09 21:25:51 +00:00 committed by Robert Marko
parent 44b809b73d
commit ac9e968a6f
1 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c
View File

@ -2747,29 +2747,14 @@ static int rtpcs_930x_sds_check_calibration(struct rtpcs_serdes *sds,
static void rtpcs_930x_phy_enable_10g_1g(struct rtpcs_serdes *sds)
{
u32 v;
/* Enable 1GBit PHY */
v = rtpcs_sds_read(sds, 0x02, MII_BMCR);
pr_info("%s 1gbit phy: %08x\n", __func__, v);
v &= ~BMCR_PDOWN;
rtpcs_sds_write(sds, 0x02, MII_BMCR, v);
pr_info("%s 1gbit phy enabled: %08x\n", __func__, v);
rtpcs_sds_write_bits(sds, 0x02, MII_BMCR, 11, 11, 0x0); /* BMCR_PDOWN */
/* Enable 10GBit PHY */
v = rtpcs_sds_read(sds, 0x04, MII_BMCR);
pr_info("%s 10gbit phy: %08x\n", __func__, v);
v &= ~BMCR_PDOWN;
rtpcs_sds_write(sds, 0x04, MII_BMCR, v);
pr_info("%s 10gbit phy after: %08x\n", __func__, v);
rtpcs_sds_write_bits(sds, 0x04, MII_BMCR, 11, 11, 0x0); /* BMCR_PDOWN */
/* dal_longan_construct_mac_default_10gmedia_fiber */
v = rtpcs_sds_read(sds, 0x1f, 11);
pr_info("%s set medium: %08x\n", __func__, v);
v |= BIT(1);
rtpcs_sds_write(sds, 0x1f, 11, v);
pr_info("%s set medium after: %08x\n", __func__, v);
rtpcs_sds_write_bits(sds, 0x1f, 11, 1, 1, 0x1);
}
static int rtpcs_930x_sds_10g_idle(struct rtpcs_serdes *sds)