catspeed-cc/openwrt
2
1
Fork 0
Code Issues Pull Requests Activity

netifd: ensure netifd_loglevel default value as fallback

Browse Source 
Commit 168d5af added the possibility to configure netifd logging level.
The option is read from /etc/config/network and validated.
Supposedly the validation sets 2 as default.

But in case of a syntax error in /etc/config/network, the validation
result can be empty. Then the always passed option to netifd is
just '-l' instead of '-l 2'. That crashes netifd and prevents network
from launching.

Add a fallback value to the variable, so that there will always be
a proper value after the '-l' option.

Improves: 168d5af "netifd: add loglevel config option (fixes #18001)"
Fixes: #21816

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Link: https://github.com/openwrt/openwrt/pull/21819
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Hannu Nyman 2026-02-01 18:28:57 +02:00 committed by Robert Marko
parent b7cd16dba3
commit b800595a38
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package/network/config/netifd/files/etc/init.d/network
View File

@ -19,7 +19,7 @@ start_service() {
procd_open_instance
procd_set_param command /sbin/netifd
procd_append_param command -l ${netifd_loglevel}
procd_append_param command -l ${netifd_loglevel:-2}
procd_set_param respawn
procd_set_param watch network.interface
[ -e /proc/sys/kernel/core_pattern ] && {