catspeed-cc/openwrt
2
1
Fork 0
Code Issues Pull Requests Activity

realtek: pcs: rtl930x: drop superfluous debug prints

Browse Source 
The RTL930x calibration code is especially chatty. There are debug
prints for every start and end of a section corresponding to the
sections the SDK uses. In the end, this doesn't help a user much and
just wastes CPU cycles. Moreover it doesn't help in understand what is
done there. As a first step, drop "start" and "end" prints but preserve
their meaning as comments.

While at it, slightly adjust two other prints and drop one confusing
print.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23288
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Jonas Jelonek 2026-05-10 18:44:30 +00:00 committed by Robert Marko
parent ac9e968a6f
commit 6a3db77f2b
1 changed files with 27 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c
View File

@ -2123,9 +2123,7 @@ static u32 rtpcs_930x_sds_rxcal_leq_read(struct rtpcs_serdes *sds)
leq_manual = !!rtpcs_sds_read_bits(sds, 0x2e, 0x18, 15, 15); leq_manual = !!rtpcs_sds_read_bits(sds, 0x2e, 0x18, 15, 15);
leq_bin = rtpcs_930x_sds_rxcal_gray_to_binary(leq_gray); leq_bin = rtpcs_930x_sds_rxcal_gray_to_binary(leq_gray);
pr_info("LEQ gray: %u, LEQ bin: %u", leq_gray, leq_bin); pr_info("LEQ gray: %u, LEQ bin: %u, LEQ manual: %u\n", leq_gray, leq_bin, leq_manual);
pr_info("LEQ manual: %u", leq_manual);
return leq_bin; return leq_bin;
} }
@ -2278,8 +2276,8 @@ static void rtpcs_930x_sds_do_rx_calibration_1(struct rtpcs_serdes *sds,
int tap0_init_val = 0x1f; /* Initial Decision Fed Equalizer 0 tap */ int tap0_init_val = 0x1f; /* Initial Decision Fed Equalizer 0 tap */
int vth_min = 0x1; int vth_min = 0x1;
pr_info("start_1.1.1 initial value for sds %d\n", sds->id); /* 1.1.1 --- */
rtpcs_sds_write(sds, 6, 0, 0); rtpcs_sds_write(sds, 6, 0, 0); /* initial value */
/* FGCAL */ /* FGCAL */
rtpcs_sds_write_bits(sds, 0x2e, 0x01, 14, 14, 0x00); rtpcs_sds_write_bits(sds, 0x2e, 0x01, 14, 14, 0x00);
@ -2319,16 +2317,14 @@ static void rtpcs_930x_sds_do_rx_calibration_1(struct rtpcs_serdes *sds,
rtpcs_sds_write_bits(sds, 0x2e, 0x13, 2, 0, 0x07); rtpcs_sds_write_bits(sds, 0x2e, 0x13, 2, 0, 0x07);
rtpcs_sds_write_bits(sds, 0x2f, 0x0b, 5, 3, vth_min); rtpcs_sds_write_bits(sds, 0x2f, 0x0b, 5, 3, vth_min);
pr_info("end_1.1.1 --\n"); /* --- 1.1.1 */
pr_info("start_1.1.2 Load DFE init. value\n");
/* 1.1.2 Load DFE initial value --- */
rtpcs_sds_write_bits(sds, 0x2e, 0x0f, 13, 7, 0x7f); rtpcs_sds_write_bits(sds, 0x2e, 0x0f, 13, 7, 0x7f);
pr_info("end_1.1.2\n"); /* --- 1.1.2 */
pr_info("start_1.1.3 disable LEQ training,enable DFE clock\n");
/* 1.1.3 disable LEQ training, enable DFE clock --- */
rtpcs_sds_write_bits(sds, 0x2e, 0x17, 7, 7, 0x00); rtpcs_sds_write_bits(sds, 0x2e, 0x17, 7, 7, 0x00);
rtpcs_sds_write_bits(sds, 0x2e, 0x17, 6, 2, 0x00); rtpcs_sds_write_bits(sds, 0x2e, 0x17, 6, 2, 0x00);
rtpcs_sds_write_bits(sds, 0x2e, 0x0c, 8, 8, 0x00); rtpcs_sds_write_bits(sds, 0x2e, 0x0c, 8, 8, 0x00);
@ -2336,15 +2332,13 @@ static void rtpcs_930x_sds_do_rx_calibration_1(struct rtpcs_serdes *sds,
rtpcs_sds_write_bits(sds, 0x2e, 0x12, 14, 14, 0x00); rtpcs_sds_write_bits(sds, 0x2e, 0x12, 14, 14, 0x00);
rtpcs_sds_write_bits(sds, 0x2f, 0x02, 15, 15, 0x00); rtpcs_sds_write_bits(sds, 0x2f, 0x02, 15, 15, 0x00);
pr_info("end_1.1.3 --\n"); /* --- 1.1.3 */
pr_info("start_1.1.4 offset cali setting\n");
/* 1.1.4 offset cali setting --- */
rtpcs_sds_write_bits(sds, 0x2e, 0x0f, 15, 14, 0x03); rtpcs_sds_write_bits(sds, 0x2e, 0x0f, 15, 14, 0x03);
/* --- 1.1.4 */
pr_info("end_1.1.4\n"); /* 1.1.5 LEQ and DFE setting --- */
pr_info("start_1.1.5 LEQ and DFE setting\n");
/* assume this is equivalent with (PHY_TYPE == SERDES && MEDIA == FIBER_10G) for now */ /* assume this is equivalent with (PHY_TYPE == SERDES && MEDIA == FIBER_10G) for now */
if (hw_mode == RTPCS_SDS_MODE_10GBASER) { if (hw_mode == RTPCS_SDS_MODE_10GBASER) {
@ -2361,12 +2355,12 @@ static void rtpcs_930x_sds_do_rx_calibration_1(struct rtpcs_serdes *sds,
rtpcs_sds_write_bits(sds, 0x2f, 0x0b, 15, 9, 0x3c); rtpcs_sds_write_bits(sds, 0x2f, 0x0b, 15, 9, 0x3c);
rtpcs_sds_write_bits(sds, 0x2e, 0x0b, 1, 0, 0x03); rtpcs_sds_write_bits(sds, 0x2e, 0x0b, 1, 0, 0x03);
pr_info("end_1.1.5\n"); /* --- 1.1.5 */
} }
static void rtpcs_930x_sds_do_rx_calibration_2_1(struct rtpcs_serdes *sds) static void rtpcs_930x_sds_do_rx_calibration_2_1(struct rtpcs_serdes *sds)
{ {
pr_info("start_1.2.1 ForegroundOffsetCal_Manual\n"); /* 1.2.1 ForegroundOffsetCal_Manual --- */
/* Gray config endis to 1 */ /* Gray config endis to 1 */
rtpcs_sds_write_bits(sds, 0x2f, 0x02, 2, 2, 0x01); rtpcs_sds_write_bits(sds, 0x2f, 0x02, 2, 2, 0x01);
@ -2374,7 +2368,7 @@ static void rtpcs_930x_sds_do_rx_calibration_2_1(struct rtpcs_serdes *sds)
/* ForegroundOffsetCal_Manual(auto mode) */ /* ForegroundOffsetCal_Manual(auto mode) */
rtpcs_sds_write_bits(sds, 0x2e, 0x01, 14, 14, 0x00); rtpcs_sds_write_bits(sds, 0x2e, 0x01, 14, 14, 0x00);
pr_info("end_1.2.1"); /* --- 1.2.1 */
} }
static void rtpcs_930x_sds_do_rx_calibration_2_2(struct rtpcs_serdes *sds) static void rtpcs_930x_sds_do_rx_calibration_2_2(struct rtpcs_serdes *sds)
@ -2391,7 +2385,7 @@ static void rtpcs_930x_sds_do_rx_calibration_2_3(struct rtpcs_serdes *sds)
u32 fgcal_binary, fgcal_gray; u32 fgcal_binary, fgcal_gray;
u32 offset_range; u32 offset_range;
pr_info("start_1.2.3 Foreground Calibration\n"); /* 1.2.3 Foreground Calibration --- */
for (int run = 0; run < 10; run++) { for (int run = 0; run < 10; run++) {
/* REG_DBGO_SEL */ /* REG_DBGO_SEL */
@ -2422,7 +2416,7 @@ static void rtpcs_930x_sds_do_rx_calibration_2_3(struct rtpcs_serdes *sds)
rtpcs_sds_write_bits(sds, 0x2e, 0x15, 15, 14, offset_range); rtpcs_sds_write_bits(sds, 0x2e, 0x15, 15, 14, offset_range);
rtpcs_930x_sds_do_rx_calibration_2_2(sds); rtpcs_930x_sds_do_rx_calibration_2_2(sds);
} }
pr_info("%s: end_1.2.3\n", __func__); /* --- 1.2.3 */
} }
static void rtpcs_930x_sds_do_rx_calibration_2(struct rtpcs_serdes *sds) static void rtpcs_930x_sds_do_rx_calibration_2(struct rtpcs_serdes *sds)
@ -2436,9 +2430,7 @@ static void rtpcs_930x_sds_do_rx_calibration_2(struct rtpcs_serdes *sds)
static void rtpcs_930x_sds_rxcal_3_1(struct rtpcs_serdes *sds, static void rtpcs_930x_sds_rxcal_3_1(struct rtpcs_serdes *sds,
enum rtpcs_sds_mode hw_mode) enum rtpcs_sds_mode hw_mode)
{ {
pr_info("start_1.3.1"); /* 1.3.1 --- */
/* ##1.3.1 */
if (hw_mode != RTPCS_SDS_MODE_10GBASER && if (hw_mode != RTPCS_SDS_MODE_10GBASER &&
hw_mode != RTPCS_SDS_MODE_1000BASEX && hw_mode != RTPCS_SDS_MODE_1000BASEX &&
hw_mode != RTPCS_SDS_MODE_SGMII) hw_mode != RTPCS_SDS_MODE_SGMII)
@ -2447,7 +2439,7 @@ static void rtpcs_930x_sds_rxcal_3_1(struct rtpcs_serdes *sds,
rtpcs_sds_write_bits(sds, 0x2e, 0x17, 7, 7, 0x0); rtpcs_sds_write_bits(sds, 0x2e, 0x17, 7, 7, 0x0);
rtpcs_930x_sds_rxcal_leq_manual(sds, false, 0); rtpcs_930x_sds_rxcal_leq_manual(sds, false, 0);
pr_info("end_1.3.1"); /* --- 1.3.1 */
} }
static void rtpcs_930x_sds_rxcal_3_2(struct rtpcs_serdes *sds, static void rtpcs_930x_sds_rxcal_3_2(struct rtpcs_serdes *sds,
@ -2473,7 +2465,7 @@ static void rtpcs_930x_sds_rxcal_3_2(struct rtpcs_serdes *sds,
if (hw_mode != RTPCS_SDS_MODE_10GBASER) if (hw_mode != RTPCS_SDS_MODE_10GBASER)
pr_warn("%s: LEQ only valid for 10GR!\n", __func__); pr_warn("%s: LEQ only valid for 10GR!\n", __func__);
pr_info("start_1.3.2"); /* 1.3.2 --- */
for (i = 0; i < 10; i++) { for (i = 0; i < 10; i++) {
sum10 += rtpcs_930x_sds_rxcal_leq_read(sds); sum10 += rtpcs_930x_sds_rxcal_leq_read(sds);
@ -2511,9 +2503,9 @@ static void rtpcs_930x_sds_rxcal_3_2(struct rtpcs_serdes *sds,
} }
} }
pr_info("Sds:%u LEQ = %u", sds->id, rtpcs_930x_sds_rxcal_leq_read(sds)); pr_info("SDS %u LEQ = %u", sds->id, rtpcs_930x_sds_rxcal_leq_read(sds));
pr_info("end_1.3.2"); /* --- 1.3.2 */
} }
__always_unused __always_unused
@ -2533,14 +2525,12 @@ static void rtpcs_930x_sds_do_rx_calibration_4_1(struct rtpcs_serdes *sds)
u32 vth_list[2] = {0, 0}; u32 vth_list[2] = {0, 0};
u32 tap0_list[4] = {0, 0, 0, 0}; u32 tap0_list[4] = {0, 0, 0, 0};
pr_info("start_1.4.1"); /* 1.4.1 --- */
/* ##1.4.1 */
rtpcs_930x_sds_rxcal_vth_manual(sds, false, vth_list); rtpcs_930x_sds_rxcal_vth_manual(sds, false, vth_list);
rtpcs_930x_sds_rxcal_tap_manual(sds, 0, false, tap0_list); rtpcs_930x_sds_rxcal_tap_manual(sds, 0, false, tap0_list);
mdelay(200); mdelay(200);
pr_info("end_1.4.1"); /* --- 1.4.2 */
} }
static void rtpcs_930x_sds_do_rx_calibration_4_2(struct rtpcs_serdes *sds) static void rtpcs_930x_sds_do_rx_calibration_4_2(struct rtpcs_serdes *sds)
@ -2548,7 +2538,7 @@ static void rtpcs_930x_sds_do_rx_calibration_4_2(struct rtpcs_serdes *sds)
u32 vth_list[2]; u32 vth_list[2];
u32 tap_list[4]; u32 tap_list[4];
pr_info("start_1.4.2"); /* 1.4.2 --- */
rtpcs_930x_sds_rxcal_vth_get(sds, vth_list); rtpcs_930x_sds_rxcal_vth_get(sds, vth_list);
rtpcs_930x_sds_rxcal_vth_manual(sds, true, vth_list); rtpcs_930x_sds_rxcal_vth_manual(sds, true, vth_list);
@ -2558,7 +2548,7 @@ static void rtpcs_930x_sds_do_rx_calibration_4_2(struct rtpcs_serdes *sds)
rtpcs_930x_sds_rxcal_tap_get(sds, 0, tap_list); rtpcs_930x_sds_rxcal_tap_get(sds, 0, tap_list);
rtpcs_930x_sds_rxcal_tap_manual(sds, 0, true, tap_list); rtpcs_930x_sds_rxcal_tap_manual(sds, 0, true, tap_list);
pr_info("end_1.4.2"); /* --- 1.4.2 */
} }
static void rtpcs_930x_sds_do_rx_calibration_4(struct rtpcs_serdes *sds) static void rtpcs_930x_sds_do_rx_calibration_4(struct rtpcs_serdes *sds)
@ -2574,7 +2564,7 @@ static void rtpcs_930x_sds_do_rx_calibration_5_2(struct rtpcs_serdes *sds)
u32 tap3_list[4] = {0}; u32 tap3_list[4] = {0};
u32 tap4_list[4] = {0}; u32 tap4_list[4] = {0};
pr_info("start_1.5.2"); /* 1.5.2 --- */
rtpcs_930x_sds_rxcal_tap_manual(sds, 1, false, tap1_list); rtpcs_930x_sds_rxcal_tap_manual(sds, 1, false, tap1_list);
rtpcs_930x_sds_rxcal_tap_manual(sds, 2, false, tap2_list); rtpcs_930x_sds_rxcal_tap_manual(sds, 2, false, tap2_list);
@ -2583,7 +2573,7 @@ static void rtpcs_930x_sds_do_rx_calibration_5_2(struct rtpcs_serdes *sds)
mdelay(30); mdelay(30);
pr_info("end_1.5.2"); /* --- 1.5.2 */
} }
static void rtpcs_930x_sds_do_rx_calibration_5(struct rtpcs_serdes *sds, static void rtpcs_930x_sds_do_rx_calibration_5(struct rtpcs_serdes *sds,
@ -2621,7 +2611,6 @@ static void rtpcs_930x_sds_do_rx_calibration(struct rtpcs_serdes *sds,
/* Do this only for 10GR mode */ /* Do this only for 10GR mode */
if (hw_mode == RTPCS_SDS_MODE_10GBASER) { if (hw_mode == RTPCS_SDS_MODE_10GBASER) {
pr_info("%s: SDS enabled\n", __func__);
latch_sts = rtpcs_sds_read_bits(sds, 0x4, 1, 2, 2); latch_sts = rtpcs_sds_read_bits(sds, 0x4, 1, 2, 2);
mdelay(1); mdelay(1);
latch_sts = rtpcs_sds_read_bits(sds, 0x4, 1, 2, 2); latch_sts = rtpcs_sds_read_bits(sds, 0x4, 1, 2, 2);